BehaviorTree/BehaviorTree.CPP

Confusing input for the parallel all node.

Opened this issue · 0 comments

The parallel all node has an input named "max_failures". This input is described as "If the number of children returning FAILURE exceeds this value, ParallelAll returns FAILURE"

From the name and description I would expect that the node returns failure if the number of children failures > max_failures. But it is implemented as >=.

I feel that changing the behavior would be a massive breaking change as suddenly the failure condition changes. So maybe we change the input to a better name and description.

Similarly, I could not find documentation for this node. It would be great if this is added.