File description is used like a program name in Windows
Closed this issue · 4 comments
https://stackoverflow.com/questions/15495613/correct-usage-of-the-versioninfo-resource
It is up for debate whether we should put the application name or the description (like I have done in 3cf2f62) into that field . See also: mxre/winres#43
I think the application name should be used for FileDescription, since that property is what's used as the program name in Task Manager.
Yeah, it's weird when a sentence describing what the program does is inserted in places where you'd expect a name (as in the screenshot above). I should probably fix this and also redo the pictures in the README.md.
I did some more research on this, and other toolkits faced the exact same problem, with the timeline being:
- "Fix" the "bug" that product name is put into
FileDescriptioninstead of the description electron-userland/electron-builder#7897 - Windows uses this description as the process name everywhere, people file bugs electron-userland/electron-builder#8599
- The "fix" is reverted: electron-userland/electron-builder#8601
If we were to apply the current logic to ripgrep, it would look like this:
That's clearly wrong, so it has to be fixed here in the winresource crate. The FileDescription must be the package name.
Fixed in 0921b8a (Use package name as FileDescription because Windows uses FileDescription as application name in tools and dialogs.)