Ensembl/WiggleTools

README: Instructions miss to initialize HTSlib submodules

Closed this issue · 3 comments

WiggleTools/README.md

Lines 56 to 62 in b082056

#### Installing the htslib library
```
git clone https://github.com/samtools/htslib.git
cd htslib
make install
```

The above instructions miss to initialize the submodules as documented by HTSlib:

https://github.com/samtools/htslib/blob/f307dfbf5c7723956e788e0bdab269fe3d626b83/INSTALL#L66-L72

Dear @paulmenzel ,

Thank you for your interest in Wiggletools, and for flagging this up to us.

For the records, and while waiting for the PR, please find below a couple of ways to fix this.

After having clones the htslib repo

cd htslib
git submodule update --init --recursive
make install

Or even before cloning the htslib repo, to install the htslib library

git clone --recurse-submodules https://github.com/samtools/htslib.git
cd htslib
make install

Hello both,

Thanks for the report and the fix, the PR was just merged.

Regards,

Daniel

@sgiorgetti, thank you for documenting the instructions also in this issue.

@ALL, thank you for the quick improvement done by merge/pull request #81.

PS: If you add the tag

Resolves: #80

GitHub is going to link the issue and merge/pull request and automatically close the issue, once the merge/pull request is submitted.