Refactor dataset_curator.js
Closed this issue · 3 comments
@brianherb @JPReceveur @DanLesperance
I think it’s good for testing. Go to https://devel.umgear.org/dataset_curator.html
Couple of notes:
- The left-hand navigation menu and the header (with Joshua’s placeholder name) are placeholders for now.
- Since the gene expression search/results page has not been remade, you cannot click on a “dataset curator” link from within a dataset in the results. But you can add ?dataset_id= to the end of the URL to quickly get to that dataset
- For some select boxes, I was using the default “success” and “danger” colors, which unfortunately in the new gEAR colorscheme are a bit too bright to see. I didn’t want to overload the page with checkmarks and X’s, so I may write custom code to lower the “neon-ness” of those elements.
- I still have not implemented a color palette option for continuous colorschemes for Plotly plots. I like the examples I did for the v1 multigene curator, and will probably port that over to the dataset curator. I would also like to make it possible to choose a color palette for scanpy plots (tsne/umap static plots), but that takes a little API rewriting.
- When you choose metadata for parameters (x-axis, y-axis, color, etc), I was thinking of sorting them into defined "categorical" and "continuous" groups within the select box. I feel this makes sense since certain parameter options are triggered if a selected data series is on or the other. Thoughts?
I still may clean up the tSNE options in the post-plot view.. hadn’t decided yet though. There are quite a few but not enough to categorize them into a dropdown in my opinion.
Looking great! A couple thoughts so far:
-
categorical vs continuous sounds good to me (especially coupled with Joshua's changes to the uploader to track series type specifically
-
Reduce placement of download json config (maybe below save as new display). Its going to be a fairly rare user who uses this option.
maybe make the scroll bar in plot type and plot configuration dropdown visible by default rather than hidden (or some other way to remind people that there are more options) -
Hide 'Number of subplot columns' until a user selects plot by subplot
-
If you are scrolling down on the plot options and move to click a checkbox, the scroll bar can be in the way and prevent clicking the box (could also just be my screen)
-
Ability to change gene while on second plot screen. This one doesn't impact us too much but for people who are familiar with the genes and what to expect they would probably want to be able to put a new gene in the search here instead of going back to the previous page, opening the dropdown, and replotting.
-
When swapping between datasets(i.e. make a plot, hit go back and then select a new dataset), the checkmarks stay around even when nothing is selected.
![Screenshot 2023-09-15 at 2 04 28 PM](https://private-user-images.githubusercontent.com/28451557/268360519-f144e092-01f4-4788-9dc6-20ecb421d5f3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2NzYyNTQsIm5iZiI6MTcyNTY3NTk1NCwicGF0aCI6Ii8yODQ1MTU1Ny8yNjgzNjA1MTktZjE0NGUwOTItMDFmNC00Nzg4LTlkYzYtMjBlY2I0MjFkNWYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDAyMjU1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBiZGQxNzM5NmIyYTdmZWE5MmI0N2U5OTAyOTlkNmIxNzVmMzdkYjFjZTg4MTk1YmQ1YWRkMmVmYTJkNzU3MTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NQHPjOnLDX4LPw3qLI43aqsx11lJoh7OgpsNzVu3bjE)
Good feedback. I'll make some changes (along with a couple I had in my own previous comment), then throw the latest back on the development server. Thanks for testing