LUMC/pytest-workflow

Feature request - making custom tests interoperable with `@pytest.mark.parametrize`

Opened this issue · 2 comments

theJasonFan commented

Thanks for the great tool. How much work would it take to make custom pytest-workflow tests to play nice with @pytest.mark.parametrize?

I believe that tests that use and are annotated by @pytest.mark.parametrize and pytest workflow's @pytest.mark.workflow will always be skipped if @pytest.mark.workflow marks the test for multiple workflows. I.e.

  • A custom test for multiple workflows with no parametrization is ok.
  • A custom test for a single workflow with parametrization is ok.
  • A custom test for multiple workflows with parametrization is not ok and is always skipped

Would this be a reasonable feature request? If there is a reasonably straightforward solution, I would not mind taking a crack at it with some input and guidance from maintainers here.

Thanks!

rhpvorderman commented

How much work would it take to make custom pytest-workflow tests to play nice with @pytest.mark.parametrize?

That's not a use case we have, so I cannot justify putting quite a lot of time in it. Most of the time will be getting into the details of the pytest API.

Would this be a reasonable feature request? If there is a reasonably straightforward solution, I would not mind taking a crack at it with some input and guidance from maintainers here.

By all means!
It looks like there is already parametrization going on with the workflow mark itself in this function: https://github.com/LUMC/pytest-workflow/blob/develop/src/pytest_workflow/plugin.py#L211.
You could check out how it works and fix it to work properly with other parametrized tests.

theJasonFan commented

That's not a use case we have, so I cannot justify putting quite a lot of time in it. Most of the time will be getting into the details of the pytest API.

Totally fair. No guarantees from my side either. I will update if I end up giving this a shot!