LieberInstitute/spatialLIBD

Color Blending for NA values in `vis_clus`

boyiguo1 opened this issue · 3 comments

boyiguo1 commented

If I understand correctly, the color blending for NA values are not implemented in vis_clus yet.

spatialLIBD/R/vis_clus_p.R

Line 115 in bceb64d

scale_fill_manual(values = colors) +

Referencing to vis_gene, I think the implementation for vis_clus should be fairly easy, by adding na.value = "#CCCCCC40" to scale_fill_manual function

boyiguo1 commented

Also, currently, there is no way to change the fill value for NA in clustervar from the default dark grey to anything else using the colors argument, unless to manually create a level for NA in clustervar

lcolladotor commented

Yes, that's true that you would need to some workarounds to control the color of NA values.

lcolladotor commented

@boyiguo1, version 1.13.6 now implements the na_color option on vis_clus_p(), vis_clus(), and vis_grid_clus().