[BUG] Wrong image on tutorial classical kernels
emgilfuster opened this issue · 12 comments
Issue description
-
Expected behavior: The first image in https://pennylane.ai/qml/demos/tutorial_classical_kernels.html should be https://github.com/PennyLaneAI/qml/blob/master/demonstrations/classical_kernels/flowchart.PNG
-
Actual behavior: The first image in https://pennylane.ai/qml/demos/tutorial_classical_kernels.html is https://github.com/PennyLaneAI/qml/blob/master/demonstrations/quantum_analytic_descent/flowchart.png
Additional information
I looked into the python file (https://github.com/PennyLaneAI/qml/blob/master/demonstrations/tutorial_classical_kernels.py) from where the rst file is created, and the image address is correctly written there.
I tried to rename the image and use the new name in the python file, but then I can't build the site locally with sphinx anymore, there must be another reference to the image name somewhere that I don't understand.
Hey @emgilfuster, I have a feeling this is because Sphinx -- when processing images -- is not case sensative 🤔 So the .png and .PNG is not properly differentiated.
A fix could be to give the two images different names
Thanks @josh146! I tried to fix it that way but sphinx failed to build locally. Maybe I did something wrong, I'll try again
@emgilfuster if you want you can just push it as a PR here :) That way the CI/CD will run, and a built version will be available in the PR.
Sorry, I didn't abandon this, I'm planning to take care of it.
Thanks for the hint on how to get the build right :)
Thanks for taking care of this @emgilfuster!
Hey @emgilfuster 👋 once you have done the PR, this rocket will appear below, just click on "view deployment".
Let us know if you have any problems :)
Hi! Thanks, I'm sorry, I'm struggling to find a moment of peace for this.
I'll let you guys know, hopefully soon!
Thanks for the PR @emgilfuster ! There seems to be a problem and it does not pass the tests. At the bottom of the PR you can see it. If the tests pass, a button with a rocket will appear to see the changes. I'll take a look to see why you are getting the error
Thanks for the very quick response @KetpuntoG.
I notice my PR is very muddy because of former PRs, would I make your life easier if I erase my existing fork and make a new one from scratch? Then there would be fewer commits that could be the source of the problems.
Sorry that solving this takes your time too.
Don't worry, it's not necessary. I left you a comment in the PR 😄