PlotJuggler/plotjuggler-ros-plugins

Build error with colcon build on ROS2

brkay54 opened this issue · 1 comments

Hi, after the last commits I receiver build error as below:

berkay@ade:~/ws_plotjuggler$ colcon build
Starting >>> plotjuggler
Starting >>> plotjuggler_msgs
Finished <<< plotjuggler [3.07s]                                                            
Finished <<< plotjuggler_msgs [3.56s]                  
Starting >>> plotjuggler_ros
--- stderr: plotjuggler_ros                             
/home/berkay/ws_plotjuggler/src/plotjuggler-ros-plugins/plugins/DataStreamROS2/datastream_ros2.cpp: In member function ‘void DataStreamROS2::subscribeToTopic(const string&, const string&)’:
/home/berkay/ws_plotjuggler/src/plotjuggler-ros-plugins/plugins/DataStreamROS2/datastream_ros2.cpp:193:27: error: ‘adapt_request_to_offers’ is not a member of ‘PJ’; did you mean ‘Rosbag2QoS::adapt_request_to_offers’?
  193 |   auto detected_qos = PJ::adapt_request_to_offers(topic_name, publisher_info);
      |                           ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/berkay/ws_plotjuggler/src/plotjuggler-ros-plugins/plugins/DataStreamROS2/datastream_ros2.cpp:10:
/home/berkay/ws_plotjuggler/src/plotjuggler-ros-plugins/plugins/DataStreamROS2/rosbag2_helper.hpp:11:20: note: ‘Rosbag2QoS::adapt_request_to_offers’ declared here
   11 | inline rclcpp::QoS adapt_request_to_offers(
      |                    ^~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [plugins/CMakeFiles/DataStreamROS2.dir/build.make:76: plugins/CMakeFiles/DataStreamROS2.dir/DataStreamROS2/datastream_ros2.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:189: plugins/CMakeFiles/DataStreamROS2.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
---
Failed   <<< plotjuggler_ros [4.21s, exited with code 2]

Summary: 2 packages finished [7.93s]
  1 package failed: plotjuggler_ros
  1 package had stderr output: plotjuggler_ros

After I changed line 193 to:
auto detected_qos = Rosbag2QoS::adapt_request_to_offers(topic_name, publisher_info);
issue solved.
I don't know it is because of me or not.

fixed