STORM-IRIT/OpenGR

reserved identifier violation

Closed this issue · 5 comments

I would like to point out that identifiers like “_OPENGR_ACCELERATORS_KDTREE_H” and “_PCS_UTILS_H_do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

Hi @elfring ,

Yes thanks for pointing this, that's true.
I think my preferred option would be to use #pragma once everywhere.
I know it is not standard.

How do you think about to achieve standard compliance?

Commit 9432643 changes all include guars to pragma once.

Yes I know, but it Is supported by most compilers.
If some users have an issue with this one day, I'll fix it.