glMDplot changes numeric columns with NAs to character in bottom table
Opened this issue · 2 comments
jdrnevich commented
When you have a numeric column in your annotation that has NA values, it somehow gets changed to character in the bottom table in a glMDPlot, so that sorting on it ends up with 1, 10, 100, 101, 102, etc. I couldn't find where this was occurring. Anyway to fix this so clicking on the table will sort properly as 1, 2, 3, etc?
Thanks!
Shians commented
Hmm might be tricky to fix, since Javascript doesn't have a similar notion of NA, I can either change to conversion such that it becomes NaN or NULL Javascript values but I'd have to test the effects of this.
jdrnevich commented
I thought it must be something on the inside! Thanks for trying to fix it.
From: Shian Su [mailto:notifications@github.com]
Sent: Wednesday, October 18, 2017 11:50 PM
To: Shians/Glimma <Glimma@noreply.github.com>
Cc: Zadeh, Jenny Drnevich <drnevich@illinois.edu>; Author <author@noreply.github.com>
Subject: Re: [Shians/Glimma] glMDplot changes numeric columns with NAs to character in bottom table (#147)
Hmm might be tricky to fix, since Javascript doesn't have a similar notion of NA, I can either change to conversion such that it becomes NaN or NULL Javascript values but I'd have to test the effects of this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#147 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKJIWY7_A0KBtsWG7T-avE95YuPbLwZLks5sttULgaJpZM4P96ny>.