Requires default_uri to be defined
akincer opened this issue · 5 comments
akincer commented
This might confuse some folks that are getting localhost as the root of the generated URI due to url() in twig prepending localhost without having default_uri defined in routing.yaml.
weaverryan commented
I don't think we can require default_uri in this bundle, as it comes from another bundle. However, this is definitely an easy place to mess up, so it could definitely be mentioned in the README - like if you're getting localhost URLs on production, you should set this.
akincer commented
Right. Should have been more explicit - for production and a note in the
README was exactly what I had in mind.
…On Mon, Oct 31, 2022, 10:01 AM Ryan Weaver ***@***.***> wrote:
I don't think we can require default_uri in this bundle, as it comes from
another bundle. However, this is definitely an easy place to mess up, so it
could definitely be mentioned in the README - like if you're getting
localhost URLs on production, you should set this.
—
Reply to this email directly, view it on GitHub
<#249 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKNL5HCOLKKYFSXM7RBHTWF7GMDANCNFSM6AAAAAARTDLSLQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
weaverryan commented
PR warmly welcomed for this :)
akincer commented
Created. If the wording needs changed just let me know.
bocharsky-bw commented
Just for reference: #250