TheAssemblyArmada/Thyme

Bool treated as integer in InGameUI::Select_Matching_Across_Region

xezon opened this issue · 0 comments

xezon commented
                for (Drawable *drawable = g_theGameClient->First_Drawable(); drawable != nullptr;
                     drawable = drawable->Get_Next()) {
                    count += Similar_Unit_Selection(drawable, &data);
                }

Probably should be written as

                for (Drawable *drawable = g_theGameClient->First_Drawable(); drawable != nullptr;
                     drawable = drawable->Get_Next()) {
                    if (Similar_Unit_Selection(drawable, &data)) {
                        ++count;
                    }
                }

It also does so in InGameUI::Select_All_Units_By_Type_Across_Region.