TheAssemblyArmada/Thyme

Release condition around assert in ShellMenuSchemeManager::Parse

xezon opened this issue · 0 comments

xezon commented
void ShellMenuSchemeManager::Parse(INI *ini)
{
    Utf8String name;
    name.Set(ini->Get_Next_Token());
    ShellMenuSchemeManager *manager = g_theShell->Get_Menu_Scheme_Manager();

    if (manager == nullptr) {
        captainslog_dbgassert(false, "ShellMenuSchemeManager::Parse: Unable to Get SMSchemeManager");
    }

    if (manager != nullptr) {
        ShellMenuScheme *scheme = manager->New_Shell_Menu_Scheme(name);
        captainslog_dbgassert(
            scheme != nullptr, "ShellMenuSchemeManager::Parse: Unable to allocate Scheme '%s'", name.Str());
        ini->Init_From_INI(scheme, ShellMenuSchemeManager::Get_Field_Parse());
    }
}

Should become

captainslog_dbgassert(manager != nullptr, "ShellMenuSchemeManager::Parse: Unable to Get SMSchemeManager");

so it can definitely compile out.