Invalid push constant ranges

[scygan]

https://github.com/Themaister/Granite/blob/3e4b24dab7e0a0f9ca7496da44cc5aa62a1d60e5/vulkan/shader.cpp#L194..L196

This fragment of code assumes, that only used (active) push constants need to be placed in the pipeline layout range.

However, the Vulkan spec says:

Similarly, the push constant block declared in each shader (if present) must only place variables at offsets that are each included in a push constant range (...)

So all declared variables should be backed by the range.

Following disabled chunk of code is more correct. It seems this is not pessimization of layers :) - this fixes crashing on at least one Vulkan implementation:

// The validation layers are too conservative here, but this is just a performance pessimization.
		size_t size =
		    compiler.get_declared_struct_size(compiler.get_type(resources.push_constant_buffers.front().base_type_id));
		layout.push_constant_offset = 0;
		layout.push_constant_range = size;

[Themaister]

Huh, weird, thanks for spotting it. I swear it used to be statically accessed, but guess not. Fixed on master.