WU-BIMAC/MicroMetaApp-React

[BUG] MANAGE INSTRUMENT Reset of field after scroll

Closed this issue · 10 comments

Akramhar commented

Describe the bug
Andrea reported that filled fields in the editor are reset after scroll up, scroll down.

To Reproduce
Alex and Utku were unable to reproduce the issue.
Caterina testing didn't present the issue.

More investigation and data is required to locate this issue.

Expected behavior
Fields should never reset unless Cancel button is pressed

Akramhar commented

@utku please add the recording of the error here and @andreacosolo if you could please report information about your browser / os setup

  • 👍1
andreacosolo commented

browser: chrome, Version 104.0.5112.101 (Official Build) (x86_64)
macOS 11 (not sure about the minor version, as I recorded this some time back)

andreacosolo commented

Utku initially reported the same/a similar issue and was able to resolve it by clearing the browser cache. On my end, I cleared the entire cache, quitted chrome, relaunched. The issue persisted.

andreacosolo commented

I can reproduce it today on both Chrome Version 106.0.5249.103 (Official Build) (x86_64) and Safari Version 16.0 (16614.1.25.9.10, 16614).
OS is macOS Version 11.7 (20G817).
The micrometa version is the one deployed on the 4DN data portal (0.0.0.21 ?)

To reproduce:

  • on the 4DN data portal, create a new microscope.
  • From the micrometa app panel, click Edit Microscope and select the tabs InvertedMicroscopeStand / ManufacturerSpec.
  • input some values
  • scroll down
  • observe that the tab selected switched back to the first one available on the left. When you go again on InvertedMicroscopeStand / ManufacturerSpec, there are no values.
strambc commented

I was able to reproduce it as well. Both on the portal and on Electron 1.7.24-b1. On Electron it required re-sizing the window.

strambc commented

Is it related to #394?

strambc commented

NO ERROR associated with the observed behavior on Electron

strambc commented

Same issue as #398

Akramhar commented

The issue is related to the resize issue and it present itself, for the best of my knowledge, only in the "edit microscope" and "edit settings" view.
In version 1.7.25-b1 I moved those form to be state, so that the content of the form should be retained after a re render occurs (for example resize event). In the test I performed it seems to correctly persist the form content.
I'll await feedback before marking the issue as closed :)

  • 👍1