Question about "Y_bbox_helper" in helper_net.py line 253
Darknesszlx opened this issue · 1 comments
Darknesszlx commented
var Y_bbox_helper in helper_net.py line 253 is used for finding valid gt boxes. After sum operation, Y_bbox_helper maybe less than 0, so adding an abs operation before greater operation maybe a better solution.
Yang7879 commented
Hi @Darknesszlx , thank you for the good suggestion. So far the sum operation is fine because we use the "zero-one-center" to preprocess the point clouds, which means all the vertices of gt boxes are always positive. But I agree with you using abs operation will make the code more reliable in case the data are preprocessed in another way.
Line 125 in b4345f2