2023.2.0a14 requires package changes.
vertxxyz opened this issue · 4 comments
As of 2023.2.0a14 (see patch notes) com.unity.textmeshpro has been merged into uGUI com.unity.ugui.
What is the current behavior?
The com.unity.textmeshpro package throws errors due to it being deprecated, and no longer supported by this editor version. It cannot be removed as YarnSpinner has a dependency on it.
Please provide the steps to reproduce, and if possible a minimal demo of the problem:
Add YarnSpinner to a 2023.2.0a14+ project.
What is the expected behavior?
No errors.
Please tell us about your environment:
- Yarn Spinner Version: 2.2.4
- Unity Version: 2023.2.0a14
Other information
YarnSpinner currently has a dependency on com.unity.textmeshpro. This will not be allowed as of 2023.2.0a14, and just causes errors.
The fix (which I may make a PR for) is to make TMP an optional dependency, and use version defines to handle the 3 cases:
- No TMP or UGUI version >2.0.0
- TMP
- UGUI version >2.0.0
I would make a PR, but the contributing guidelines are advising I work from develop, where no develop branch seems to exist. Should I just be working from the head of main?
Thank you for the heads-up! Yes, make a PR against main. I'll update the contribution guidelines.