Unexpected `8011[63]` (`Invalid motion type`) (YRC, GP25, linear track)
gavanderhoorn opened this issue · 5 comments
It looks like #176 works a little too well, in that it immediately is raised on a YRC1, GP25 on a linear track -- which is a simple system that should-just-work (tm).
Have to investigate.
@ted-miller: is MOTION_TYPE_NOT_USED
returned for axes that are not present in motion groups?
Ahhh... Yeah, I merged w/o testing. Foolish.
is MOTION_TYPE_NOT_USED returned for axes that are not present in motion groups?
Yes. There's 8 axes in EVERY group. Most are not used.
Ok. I thought so.
Should this just only look at axes which are actually configured:
motoros2/src/PositionMonitor.c
Line 295 in df3a334
?
Should this just only look at axes which are actually configured:
Yes. But it's not terribly straight-forward. The current control-group doesn't have knowledge of the base-group's axis configuration.
So it'd be something like:
g_Ros_Controller.ctrlGroups[group->baseTrackGroupIndex].axisType[i] != AXIS_INVALID
This seems like an awful lot of clutter for something that shouldn't happen and AFAICT cannot happen.
I'd be in favor of just adding a default: break;
to the switch and removing the alarm.
But I'll leave it up to you.
See #179.