Integer division for aspect ratio of bounding box?
Closed this issue · 10 comments
I just wanted to plot the aspect ratio and found that all the values are integers. You can see the results in the image I attached. Also when you export the data the values are integer only.
If you want to reproduce this you can use data from this sample folder:
\biotec-files\guck_rtdc\experiments_18_19\20190328_Felix_RBCs_Glutaraldehyde\CTRL
It is reproducible. After investigating the data file with HDFView, I noted that the "aspect" feature only contains integer values (although the data type is float). After removing this particular feature (which triggers a re-computation by dclab), the plot appears correctly:
@phidahl The data file was generated by Shape-In 2.0.6. I have another file generated by Shape-In 2.0.5 which does not exhibit this bug. Could this be a regression?
@felix-r As described above, a workaround would be to remove the "aspect" event feature from the original .rtdc file using HDFView https://www.hdfgroup.org/downloads/hdfview/. If you have many such files, I could also implement an "expert option" in Shape-Out that would force the recomputation of the "aspect" feature using dclab.
@phidahl If this bug only affects certain versions of Shape-In (specific values in the "setup:software version" attribute), then I could also implement a universal workaround in dclab.
Yes, there was a wrong variable cast in the C++ code. Thanks for telling.
The following versions >2.0.6 will be fixed.
@phidahl: Just to be sure: This only affects version 2.0.6?
@phidahl : I guess this also affects the filtering during the measurement? Say I set an aspect filter of 1.5 values up to 1.99 will still fall into the gate?
Filtering is only affected for soft-gates, but not for hard-gates.
We are working on an update..
@felix-r: Meanwhile, I have implemented a fix in dclab: DC-analysis/dclab@e22a431
I have triggered a new build of Shape-Out. Once it is finished, you can download it by clicking on "Artifacts":
https://ci.appveyor.com/project/paulmueller/shapeout/build/job/jnfm2nicet4owkuk
Let me know whether that works for you.
EDIT: here the direct link https://ci.appveyor.com/api/buildjobs/jnfm2nicet4owkuk/artifacts/.appveyor%2FOutput%2FShape-Out_0.9.2.post10_win_64bit_setup.exe
I am sorry. The affected Versions are 2.0.6 and 2.0.7 (I wronlgy assumed that the affected data came from a up-to-date setup)
Version 2.0.8 was distributed to all lab PCs yesterday. So this issue should be solved.
Could we release ShapeOut with this change already? I think it is important enough.