Zylann/solar_system_demo

Its not working in godot 4.1.

Droog159 opened this issue · 7 comments

He's not working in 4.1, how do I fix him, I'd get stuck on the initialization of Earth galaxies because they need to initialize the atmosphere and oceans, and the call to _get_material fails.

Zylann commented

This video was taken with Godot 4.1.1, so this demo should be working.

There is a number of different reasons it would not work for you, so I need a lot more details than this.

  • Are you using a build of Godot 4.1 that includes the voxel module?
  • Which errors are actually printing? Scripts, line numbers?
  • If you believe the error comes from a plugin, for example the atmosphere, have you tried using it in a new empty project? If it has a bug, it would better be reported in these plugin's repos.

I am very surprised by your reply speed, I want to confirm again, I am using the godot_voxel4 mono version, I have been learning your voxel module in recent days, he is really cool.

Zylann commented

The project runs fine for my local dev build.
It also runs fine when I use the editor build from the voxel module's CI: https://github.com/Zylann/godot_voxel/actions/runs/6342616234
So I don't know what's going wrong on your side, but you might not be running the project with the correct version of Godot.

image
image
image

system info:
Godot v4.1.2.rc (d5fab0ec4) - Windows 10.0.22000 - Vulkan (Forward+) - dedicated AMD Radeon RX 5700 XT (Advanced Micro Devices, Inc.; 31.0.14057.2005) - Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz (12 Threads)

error info:
Invalid get index 'material_override' (on base: 'Nil').
image
image

What do you mean by using the correct version, maybe I have this situation alone, my godot generates a log every time it runs, and I don't know how to shut it down. This is a bit frustrating, I want to try it with a virtual machine.

Zylann commented

Whatever this is, I'm not getting it... I have no clue what's going on in your version.

The errors inside the mannequiny folder are irrelevant, this is no longer used in the game, but for some reason Godot still tries to parse their scripts and spams errors because they are old.
Basically all the errors from your first screenshot are irrelevant, they only happen the first time you open the editor and do not happen when you run the game.
I would need the full log when running the game. Maybe something went wrong before you got to this breakpoint.

Looking at Invalid get index 'material_override' (on base: 'Nil')., it makes no sense because _mesh_instance can't possibly be null. _mesh_instance is created in _init(), which is called when the script is created, before everything else. there is no way it can be null without some ugly GDScript breakage of some sort, but I can't see what that would be. Also atmospheres are not setup while setting seas, line numbers aren't right.

I tried doing everything from scratch:
Downloaded a ZIP of the master branch of the repo, launched it from scratch using the build Godot v4.1.2.rc (d5fab0ec4), imported stuff, had some errors about the old unused scripts, launched the game, all was fine.
There is something different on your side and I don't know what it is.

Full video of me doing this from scratch:
https://zylannprods.fr/dl/godot/solar_system/solar_system_testing_from_scratch.mp4

image
I've been trying all day, I've tried running it in ubuntu, and a win10 VM, and I've set the system language to English, but it still doesn't work. Finally after thinking about the video you sent me, I think the code must be fine, I'm using an amd graphics card on my side.
Vulkan API 1.3.246 - Forward+ - Using Vulkan Device #0: AMD - AMD Radeon RX 5700 XT
Then I changed Forward+ to compatibility mode, and I found that he was able to run it without any problems. I can't thank you enough for all your help, and your videos, you are the best open source person I have ever met, and I'm impressed that you even recorded a video, my goodness. All I can say is God bless you. Thank you for everything, I've been wandering the galaxy.
This is from the translation software, so I hope they can accurately express my gratitude to you.

(ㅅ´ ˘ `)♡~

image
image
image

image
so amazing !!