Clicking slider handles or selection bar scrolls to window top

Question

Clicking slider handles or selection bar scrolls to window top

dexbytesmanish opened this issue 6 years ago · 11 comments

I am facing issue that when I click on slider handles or selection bar it scrolls to window top. can you pleas suggest way to avoid this situation ?

Answer 1 · 2018-07-27T16:43:34.000Z

Could you please provide a demo? I have never
encountered such an issue with this library.

Answer 2 · 2018-07-30T06:53:44.000Z

Hello Valentin, Please go to : https://www.the-online-gallery.com/artworks 1. Scroll down to bottom 2. Click on Price dropdown to open slider 3. Click on any handle of the price slider By just clicking handle it scrolls to window top. Thanks, Manish From: Valentin Hervieu [mailto:notifications@github.com] Sent: Friday, July 27, 2018 10:14 PM To: angular-slider/angularjs-slider Cc: dexbytesmanish; Author Subject: Re: [angular-slider/angularjs-slider] Clicking slider handles or selection bar scrolls to window top (#646) Could you please provide a demo? I have never such an issue with this library. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#646 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AlP6ZcvhMzR-dhHnxToz_9w3eGX42PWUks5uK0M3gaJpZM4VjcpO> . <https://github.com/notifications/beacon/AlP6ZXtykqf6yagAlOmLuJGq6fcXbeoEks5uK0M3gaJpZM4VjcpO.gif>

Answer 3 · 2018-07-30T06:58:24.000Z

This is not an issue with this library. The problem comes from the fact you navigate to page/1/sort-by/default%20sorting/price/1-28200 when the slider is clicked and thus, the page scrolls to top.

If you don't want this, you should only navigate when the price value has really changed.

Answer 4 · 2018-07-30T07:01:11.000Z

Hello Valentin, I am calling onEnd event so why just clicking onEnd event is triggered if price value has not really changed. Thanks, Manish From: Valentin Hervieu [mailto:notifications@github.com] Sent: Monday, July 30, 2018 12:28 PM To: angular-slider/angularjs-slider Cc: dexbytesmanish; Author Subject: Re: [angular-slider/angularjs-slider] Clicking slider handles or selection bar scrolls to window top (#646) This is not an issue with this library. The problem comes from the fact you navigate to page/1/sort-by/default%20sorting/price/1-28200 when the slider is clicked and thus, the page scrolls to top. If you don't want this, you should only navigate when the price value has really changed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#646 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AlP6ZdkQRC2V1uHvg1I1PMyKfGdZ7zhDks5uLq6RgaJpZM4VjcpO> . <https://github.com/notifications/beacon/AlP6ZRJmYJewIS4eERYksjhntHwqlveeks5uLq6RgaJpZM4VjcpO.gif>

Answer 5 · 2018-07-30T07:03:37.000Z

onEnd is called when the user finished on interaction with the slider. In this callback, you can write any custom logic to prevent unwanted actions.

Answer 6 · 2018-07-30T07:07:12.000Z

Ok, so how should I avoid this situation that if price value has not really changed not change the URL ? From: Valentin Hervieu [mailto:notifications@github.com] Sent: Monday, July 30, 2018 12:34 PM To: angular-slider/angularjs-slider Cc: dexbytesmanish; Author Subject: Re: [angular-slider/angularjs-slider] Clicking slider handles or selection bar scrolls to window top (#646) onEnd is called when the user finished on interaction with the slider. In this callback, you can write any custom logic to prevent unwanted actions. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#646 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AlP6ZYx0LOgi7h87iJT07CBJcoRkT8oFks5uLq_KgaJpZM4VjcpO> . <https://github.com/notifications/beacon/AlP6ZYJgqpgeFLP1pv5Umvfa9rNTiRYmks5uLq_KgaJpZM4VjcpO.gif>

Answer 7 · 2018-07-30T07:08:26.000Z

You can compare the new values with the previous ones, if they haven't changed, don't do anything.

Answer 8 · 2018-07-30T07:13:23.000Z

How do I get new values and previous values ? From: Valentin Hervieu [mailto:notifications@github.com] Sent: Monday, July 30, 2018 12:38 PM To: angular-slider/angularjs-slider Cc: dexbytesmanish; Author Subject: Re: [angular-slider/angularjs-slider] Clicking slider handles or selection bar scrolls to window top (#646) You can compare the new values with the previous ones, if they haven't changed, don't do anything. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#646 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AlP6ZcuaNp7XNz7LZFZVFPBqfo8oheChks5uLrDsgaJpZM4VjcpO> . <https://github.com/notifications/beacon/AlP6ZSKsqLd_mHAUjXBv2aMHP4lWXqLZks5uLrDsgaJpZM4VjcpO.gif>

Answer 9 · 2018-07-30T07:26:17.000Z

As I checked it is scrolling to window top before navigating to URL. So there must be something else to fix this. From: Valentin Hervieu [mailto:notifications@github.com] Sent: Monday, July 30, 2018 12:38 PM To: angular-slider/angularjs-slider Cc: dexbytesmanish; Author Subject: Re: [angular-slider/angularjs-slider] Clicking slider handles or selection bar scrolls to window top (#646) You can compare the new values with the previous ones, if they haven't changed, don't do anything. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#646 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AlP6ZcuaNp7XNz7LZFZVFPBqfo8oheChks5uLrDsgaJpZM4VjcpO> . <https://github.com/notifications/beacon/AlP6ZSKsqLd_mHAUjXBv2aMHP4lWXqLZks5uLrDsgaJpZM4VjcpO.gif>

Answer 10 · 2018-07-30T07:32:38.000Z

You need to store the previous values somehow. Anyway, if you want the price slider to reflect what's in the url, you need to know what's the current selection is. Thus, compare to this.

This is custom logic so I can't help more.

Answer 11 · 2018-07-30T07:59:48.000Z

I have debugged in Web Inspector by setting breakpoint just before URL navigation and it is being observed that it is scrolling to window top before navigation. From: Valentin Hervieu [mailto:notifications@github.com] Sent: Monday, July 30, 2018 1:03 PM To: angular-slider/angularjs-slider Cc: dexbytesmanish; Author Subject: Re: [angular-slider/angularjs-slider] Clicking slider handles or selection bar scrolls to window top (#646) You need to store the previous values somehow. Anyway, if you want the price slider to reflect what's in the url, you need to know what's the current selection is. Thus, compare to this. This is custom logic so I can't help more. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#646 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AlP6ZfphrVdglqTjG-QydBItUDIvrkN7ks5uLraXgaJpZM4VjcpO> . <https://github.com/notifications/beacon/AlP6ZSTOZitzD56YtLm52b4IFdnx0_Dtks5uLraXgaJpZM4VjcpO.gif>