axiros/terminal_markdown_viewer

Setup.py requires mdv which requires markdown break "pip install mdv"

Closed this issue · 3 comments

setup.py currently requires mdv, which itself requires markdown, which "pip install mdv" in environement where dependencies are not already satisfied.

axgkl commented

hi, yes you have to deploy the dependencies (think also pyyaml and docopt, pygments) currently BEFORE you pip install mdv. sorry for that. Reason is that I have those libs at non pip default folders and did not want pip install mdv to install them. I know, its just lazyness.

Hi Gunther

The problem of this is that it breaks other projects relying on this
project- I can't put your project in my requirements file as the whole
requirements file would fail to install package properly... I have had to
fork your project to change the setup.py before to be able to use it with
my project ant the continuous integration associated with it. It should not
be required. It is easy to fix on your side and avoid other to create
technical debt with bespoke install procedures.I would really recommend
that you fix the pip install.

Bertrand

On 16 Nov 2016 11:31, "Gunther Klessinger" notifications@github.com wrote:

Closed #35 #35.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADP135ArllQQ0b6M8o_lV_DDceXDievNks5q-umcgaJpZM4Ky403
.

axgkl commented

pling, now I get it: the import mdv within setup.py was not too clever.

Since this will prevent world domination for this weekend hack I fixed it and created a little travis runner testing versus setup.py install on a clean machine, that should reflect what pip does as well (I hope).

travis was anyway due. New 1.5.0 pip version I'll do in the evening.

edit: done, please try pip install mdv now

Thanks Bertrand,
G.