axtimwalde/mpicbg

Return transformation models for reusing

Closed this issue · 5 comments

lacan commented

In the case of matrix based models, it would be useful to have a way to get these back and to reapply them, through macros for example.

lacan commented

Hi@axtimwalde, what i was hoping for was to get a return value from the Interactive Affine plugin you made. I could also just reimplement that class just for my needs, but a toString() once the Enter key is pressed. Ideally I guess I should add something to InteractiveInvertibleCoordinateTransform so that on the enter keypress the ij.log outputs the matrix used for the transform but i am afraid that this would break the generic functionality of that class.

axtimwalde commented

@lacan thanks, that wasn't clear from the initial issue message. Have you had a look at TrakEM2 and the package mpicbg-trakem2? The aim of this package is to enable import and export of mpicbg transformations, used for XML import and export in TrakEM2, RVS, and TVS. The Interactive* classes are just for testing, adding an empty abstract onReturn() method could do the job (affine and rigid could override this). Feel free to hack it, I am happy to accept reasonable pull requests. BTW, for the macro world, the Landmark Correspondences plugin in combination with ImageJ's ROI manager could be interesting.

lacan commented

Hi again. I will have a look at the TrakEM2 package for further inspiration.
I am currently using the Landmarks Correspondences (have to file a small bug there) but again it is missing the fine tuning you can get with the interactive approaches.
I'll send a pull request once I've added an overwritable onReturn method to the interactive classes and tested it on the linear transform methods. Thanks for your time!

axtimwalde commented

Resolved with 32d22f3 Thanks for the pull request.