Incorrect Kernel?

I can't see a good reason for the following line (and the one above it) to be using the horizontal kernel, I believe it should be using the vertical instead

mpicbg/mpicbg/src/main/java/mpicbg/ij/util/Filter.java

Line 307 in 050bc91

vala += h[ yk ] * tempData[ ya[ y + yk ] + x ];

I believe the lines should be:

				valb += v[ yk ] * tempData[ yb[ y + yk ] + x ];
				vala += v[ yk ] * tempData[ ya[ y + yk ] + x ];

This is probably right. But the method is not used---or is it?

It is used for SIFT feature extraction. Specifically:

mpicbg/mpicbg/src/main/java/mpicbg/ij/SIFT.java

Line 104 in 050bc91

fa = Filter.convolveSeparable( fa, initialKernel, initialKernel );

mpicbg/mpicbg/src/main/java/mpicbg/imagefeatures/FloatArray2DScaleOctave.java

Line 219 in 050bc91

    
           l[ 1 ] = Filter.convolveSeparable( l[ 0 ], KERNEL_DIFF[ STEPS ], KERNEL_DIFF[ STEPS ] );

and

mpicbg/mpicbg/src/main/java/mpicbg/imagefeatures/FloatArray2DScaleOctave.java

Line 243 in 050bc91

    
           l[ i ] = Filter.convolveSeparable( l[ 0 ], KERNEL_DIFF[ i ], KERNEL_DIFF[ i ] );

The SIFT algorithm is used by the register virtual stack slices plugin https://github.com/fiji/register_virtual_stack_slices

You are right. But in all these places the h and v kernels are always identical. Would be good to fix though. Could you do it and may be write a unit-test? Then file a pull request and I accept? Thanks, Stephan

…

On Fri, 2018-02-16 at 23:38 +0000, JonathanCSmith wrote: It is used for SIFT feature extraction. Specifically: https://github.com/axtimwalde/mpicbg/blob/050bc9110a186394ea15190fd32 6b3e32829e018/mpicbg/src/main/java/mpicbg/ij/SIFT.java#L104 https://github.com/axtimwalde/mpicbg/blob/050bc9110a186394ea15190fd32 6b3e32829e018/mpicbg/src/main/java/mpicbg/imagefeatures/FloatArray2DS caleOctave.java#L219 and https://github.com/axtimwalde/mpicbg/blob/050bc9110a186394ea15190fd32 6b3e32829e018/mpicbg/src/main/java/mpicbg/imagefeatures/FloatArray2DS caleOctave.java#L243 The SIFT algorithm is used by the register virtual stack slices plugin https://github.com/fiji/register_virtual_stack_slices — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.