bengott/meteor-avatar

disable gravatar

Closed this issue · 5 comments

Is there an option to disable gravatar at all? E.g. if one wants to use service's img or initials only.
Didn't find such option in readme...

After looking at code, it seems like initials would be put only after getting an image for gravatar fails, which is bad, imho.

+1 for this :)

On 4 December 2014 at 14:13, Kos notifications@github.com wrote:

Is there an option to disable gravatar at all? E.g. if one wants to use
service's img or initials only.
Didn't find such option in readme...

After looking at code, it seems like initials would be put only after
getting an image for gravatar fails, which is bad, imho.


Reply to this email directly or view it on GitHub
#24.

Kevin O'Hagan
@kevohagan
+0034685245319
Palma de Mallorca,
Spain

maybe we could have some global option to include and order services
something like this

Avatar.options = {
  services : [
    'google',
    'twitter',
    '_initials_'
  ]
};

though idk, what has been implemented in PR #20 (imho that PR should be resolved first)

Hi guys,

There actually is a line in the README that covers this use case:

To show initials when no avatar can be found via linked services, you don't need to define any options. This is the default functionality.

That being said, I realize that the config options have gotten confusing. And if you look back at some of the previous closed issues, this is a problem that keeps coming up.

Here's the deal:
I initially planned to add file uploads and a config UI to allow the user to choose which avatar to use (issues #9 and #10), which would have avoided most of this confusion. But then I merged in the initials PR, which made things more complicated, and then a few other PRs, and I was also busy working on other projects...

So that's where we are now. I agree that I should merge in PR #20 first and also PR #23. My next big push is still implementing #9 and #10.

Thanks for the interest! Your comments and PRs make the package better!

doesn't seem to work for me....
I believe cz of these lines and error handling on this line
So I still get 404 error on getting Gravatar, and only after that initials are supplemented.

Anyway, thanks for the reply!

Maybe I got your issue a little confused with #25. You're right, there is no way to disable using gravatars, and that probably won't change. I don't like all these 404s bouncing around, though, so all I can say is that it will get better in the future (I plan to do some refactoring while implementing #10).