bioFAM/MOFA

Missing for loop

vsomnath opened this issue · 2 comments

vsomnath commented

MOFA/mofapy/core/distributions.py

Line 168 in c20929b

return s.sum( stats.multivariate_normal.pdf(x, mean=self.params['mean'][n,:], cov=self.params['cov'][n,:,:]) )

In the above referenced line, it looks like a for-loop is missing, since the variable n is used but not defined within the function.

rargelaguet commented

This is correct, thanks for the heads up!
But just to clarify, currently we don't use multivariate normals so this line should not intervene at all .

  • 👍1
vsomnath commented

Thanks for the quick response, and the clarification!