_validate() called only on unweighted unifrac
Closed this issue · 2 comments
ChrisKeefe commented
Hi folks!
It looks like _methods._validate() is only being applied to unweighted_unifrac. If this was an intentional design decision, feel free to close/disregard this PR.
The missing validation probably isn't a big deal, but the different error messages generated across methods are making some of my q2-diversity-lib tests awkward, so I thought I'd propose a fix.
Best,
Chris
wasade commented
Unexpected, good find! Able to submit a PR by chance?
wasade commented
...and I see that our communications crossed paths... :)