biothings/biothings.api

Can manifest-based data plugins and regular data sources stay in the same folder?

newgene opened this issue · 5 comments

newgene commented

Right now, manifest-based data plugins stay in a separate folder like "plugins", and regular dumper/uploader based data sources stay in hub/dataload/sources folder.

Can we allow them in the same folder? It may just work already, let's verify and try to make it work if not.

remoteeng00 commented

IMHO, We should not do that:

  • we already have "Export" plugin function (it will export manifest-based plugins, generate plugin's code and put the exported plugin to the same folder with regular plugins
  • if we put manifest-based data plugins in the same folder with regular data sources, we will get more complicated to determine which one should be load as manifest-based plugin and which one should be load as regular plugin (it will a bit mess up)
ravila4 commented

In my experience, we already support having mixed plugin types in the src/plugins folder, but not in the hub/dataload/sources folder, which only permits dumper/uploader type plugins. MyGeneset.info is set up with mixed plugin types in the plugins folder.

remoteeng00 commented

Thanks for help me figure out that we have two types of data plugins: Manifest-based data plugins and “Advanced” data plugins. And yes they can be placed in the same src/plugins folder.
I offer that we call all "regular dumper/uploader based data sources" that stay in hub/dataload/sources folder as "data source" to make it difference to two types of "data plugin", sound good?

  • 👍1
ravila4 commented

Sounds good. @newgene I think we can close this issue, right?

newgene commented

Yes, closing this issue now.

@remoteeng00 we typically call both "data plugins": "manifest plugins" and "advanced plugins".