Check for language in parentheses for default locales other than en

Question

Check for language in parentheses for default locales other than en

adam3smith opened this issue 4 years ago · 10 comments

As per 3. here: https://github.com/citation-style-language/styles/wiki/Style-Requirements

Answer 1 · 2020-04-27T03:15:30.000Z

I also think it would be a good requirement to only allow default-locale values for which we have a matching CSL locale. Would protect against typos and defining valid locale codes for which we don't have CSL locales.

Answer 2 · 2021-12-23T19:10:38.000Z

If the default-language is af-ZA, what would we expect to see in the title?

Answer 3 · 2021-12-23T19:17:14.000Z

If the default-language is af-ZA, what would we expect to see in the title?

Good question. I think

(Afrikaans - SuidAfrika)

Answer 4 · 2021-12-23T19:28:12.000Z

That's not in https://github.com/citation-style-language/locales/wiki (and there are a few more with parens). Is there a list that maps default-locales to the desired parenthesized text?

Answer 5 · 2021-12-23T19:35:50.000Z

I also think it would be a good requirement to only allow default-locale values for which we have a matching CSL locale. Would protect against typos and defining valid locale codes for which we don't have CSL locales.

Does "matching CSL locale" mean a peek into the locales repo?

Answer 6 · 2021-12-23T19:39:19.000Z

Is there a list that maps default-locales to the desired parenthesized text?

I'm afraid not, at least not that I know of

Does "matching CSL locale" mean a peek into the locales repo?

Yes

Answer 7 · 2021-12-23T19:42:06.000Z

Is there a list that maps default-locales to the desired parenthesized text?

I'm afraid not, at least not that I know of

That would mean the best that can currently be done is

match a default-locale against a sheldon-private list of languages
If not in the list, and not en-*, just simply test for any parenthesized text

Answer 8 · 2021-12-23T19:51:08.000Z

That sounds good! We'd just have to remember to add to the list whenever we add a locale, which is not that often

Answer 9 · 2021-12-23T23:30:55.000Z

The langmap lives here. Since sheldon is fetched from its github repo for every run, changes to that file will be available in all subsequent runs.

I've done some testing, and everything seems to work. The actual feedback being presented to the user is hard-coded here.

Answer 10 · 2021-12-23T23:40:28.000Z

(meaning, I think #30 is done)