const-ae/ggupset

Manual label order in combmatrix

Rekyt opened this issue ยท 4 comments

Rekyt commented

Hi @const-ae ๐Ÿ‘‹ ,
Thank you so much for the ggupset package, I think it really helps to visualize categorical data!
I've looked at previous issues and couldn't find an answer to my question:
Is there an easy way to set the order of the y axis in the combmatrix?
InkedRplot_LI

It seems that changing factor levels doesn't affect at all the row orders of the comb matrix. I thought it was only due to ordering by frequency but it does not seem to be only driven by frequency. From what I understood looking at the code the order is set at these lines:

ggupset/R/axis_combmatrix.R

Lines 181 to 182 in d379fb5

labels <- factor(panel_params$x.labels, levels = panel_params$x.labels, ordered=TRUE)
labels_split <- strsplit(panel_params$x.labels, self$sep)

Would it be possible to have the user provide a custom order in place of the one created in labels_split?

Thanks again for the great package!

Hi Matthias,

thanks for the thoughtful issue. What you suggest sounds like a useful feature. However I am afraid, that I don't have the capacity to implement this myself. But I would be happy to accept and review a pull request.

Best,
Constantin

Rekyt commented

Hi Constantin,
Thank you for your very quick answer.
I'll try proposing a PR if I can wrap my head around a good solution.

Thanks. If you have any question, feel free to ask :)