Add surveillance personality modifier to change the max limit of how many times a ship can be scanned
Opened this issue · 0 comments
Problem Description
Prior to #9714, ships with the surveillance personality would scan ships in the system that they had not personally scanned yet. This, potentially combined with the overuse of the personality (#9894) led to undesirable behavior with surveillance fleets being extremely overbearing and annoying (#9706, #4240). #9714 updated it so that surveillance fleets now only scan ships that haven't yet been scanned by their government, meaning that each ship will only be scanned once.
The issue with this is that it now may make it so that the surveillance personality isn't sufficiently different enough from the default scanning behavior. Perhaps it's the case that the surveillance personality was intended to be very overbearing, scanning ships multiple times in case the first scan missed something. Now, if you're scanned once and the scan doesn't get you fined, you're free to do whatever you want until you leave the system. There's likely a middleground that makes more sense.
Related Issue Links
Desired Solution
Allow the surveillance personality to define how many times a ship can be scanned by a government. Keep track of how many times a specific ship has been scanned by a specific government. If the number of times that a ship has been scanned is greater than or equal to the scan limit on the fleet's personality, that ship no longer becomes a valid scan target.
Alternative Approaches
Remove the limit again so that ships can be scanned over and over again by surveillance fleets, but put a cooldown between when ships can be scanned so that it isn't so constant while lingering in a system with lots of surveillance ships will still get you scanned a lot.
Additional Context
No response