endless-sky/endless-sky

bad time format string in saved game tooltip

Closed this issue · 4 comments

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

the format string used to generate the tooltip for saved game files doesn't seem to be getting parsed fully. it's producing strings like %-I:58 AM on %-d Mar 2024

Steps to Reproduce

  1. open the game load UI
  2. hold your cursor over a saved game entry for a few seconds
  3. observe the resulting tooltip

Expected Behavior

i would assume these tooltips should produce valid date-time strings

Screenshots

image

Link to save file

No response

Operating System

nixos 24.05 uakari, linux 6.8.2, glibc 2.38

Game Source

Built from source

Game Version

commit SHA 810a8d5

Additional Information

built from nixpkgs derivation nixpkgs.endless-sky with src updated to the most recent commit

I am seeing something similar but not as bad.
1:59 AM on d Mar 2024
Only the d is not parsed. I assume it is the day of the month.

  • Windows 10
  • Continuous (2017674)
  • Continuous (24fdfcd) with PR6416 ----- Same as above
  • 0.10.4 is displayed correctly

I can reproduce it on continuous and not stable. I think 3f890aa broke it

EDIT: I can reproduce it on 3f890aa and not the commit before it, so I’m now positive that that commit broke it.

EDIT: A workaround for now is to change the date/time format to YYYY-MM-DD on the second page of the settings tab in the preferences panel
image

This is a curious issue.
I'm on Windows 10.
When I build locally with clang, I can't reproduce this.
When I build locally with mingw, I can reproduce it.
Though, not quite the same as what @xX-Dillinger-Xx is seeing:
image
The continuous release build provided by GitHub is also built with mingw, and I see the issue with that as well.

Should be fixed by 530f528