Don't display the "you have missions that require landing on [planet]" notice for bounty hunter missions
Closed this issue · 8 comments
Is there an existing issue for this?
- I have searched the existing issues
Describe the bug
You are no longer required to return to the planet of origin in order to complete bounty hunter (including marauder) missions. Therefore it doesn't make sense to display the notice "Note: you have missions that require landing on [planet] in the system you are jumping to." for these missions.
Steps to Reproduce
- Accept any mission that requires you to destroy down pirates/marauders.
- Jump out of the system
- Jump back into the system
- You get shown the notice
Expected Behavior
Don't display the notice.
Screenshots
Link to save file
Any pilot.
Operating System
MacOS
Game Source
Steam
Game Version
0.10.6
Additional Information
Related? #8779
Could you please tell which missions for example the bug works with? "Accept any mission that requires you to destroy down pirates/marauders." doesn't really help.
Start at line 2930 and work your way down to line 4032. All of those missions.
Start at line 2930 and work your way down to line 4032. All of those missions.
Ooh! I looked under the missions files, instead of the jobs one. Thanks.
Hah yeah I did the same, was getting confused why I couldn't find the damn missions.
How I'd fix this easily is b modifying the code so that these messages can't be displayed if the mission has an apparent payment attribute, as they're used only in bounty and marauder missions in the game vanilla data. But a better way in my opinion would be to add an attribute to missions, like no landing or no landing message, that'd disable these messages.
I'd like to get your opinion on that before working on a fix and creating a PR.
My opinion? That's very kind but I'm not a dev, so my opinion isn't so useful here :)
Worth noting that if a no landing attribute is added it might also help with solving #9993.
My opinion? That's very kind but I'm not a dev, so my opinion isn't so useful here :)
Worth noting that if a
no landingattribute is added it might also help with solving #9993.
It won't help with this other issue, as the problem of this other issues is just that in the game engine, failed missions get removed from the list only after changing of system or landing.
This has been fixed by the PR, you can close the issue.