stripplot failure in get_peaktable

Question

stripplot failure in get_peaktable

Closed this issue 10 months ago · 4 comments

Hi Ethan,
I'm just getting familiar with your ChromatographR package and am very excited by it, so thanks, but haven't had any luck producing a stripplot with the argument plot_it=T in get_peaktable - most of the striplot code gets written to the console but nothing is plotted...is this a known bug?

Answer 1 · 2023-08-30T02:39:43.000Z

Hi Ben,
Thank you very much for pointing this out. It seems I broke the code for the plot a while ago, but I didn't realize it since I don't use that plot very often. This should be fixed by 53bec5e. I also added a test so I will notice if it breaks again. I think it should work for you now after you reinstall from the master branch (and reset your R session). Let me know!
Ethan

Answer 2 · 2023-08-30T03:29:14.000Z

Thanks Ethan, I’ll check that out and let you know Cheers Dr Ben Moore, Associate Professor | Ecologist Hawkesbury Institute for the Environment | Western Sydney University Hawkesbury Campus (Richmond), Building R2, Room 1.45 Postal address: Locked Bag 1797, Penrith 2751, NSW, Australia T: +61 (0)2 4570 1384 |M: +61 412 245474 E: ***@***.******@***.***> Twitter: @blinkybenjy | web: www.uws.edu.au/hie/benmoore [signature_757244822] Western Sydney University acknowledges the Darug, Eora, Dharawal and Wiradjuri peoples and thanks them for their support of its work on their lands From: Ethan Bass ***@***.***> Reply to: ethanbass/chromatographR ***@***.***> Date: Wednesday, 30 August 2023 at 12:43 To: ethanbass/chromatographR ***@***.***> Cc: Ben Moore ***@***.***>, Author ***@***.***> Subject: [External] Re: [ethanbass/chromatographR] stripplot failure in get_peaktable (Issue #28) Hi Ben, Thank you very much for pointing this out. It seems I broke the code for the plot a while ago, but I didn't realize it since I don't use that plot very often. This should be fixed by 53bec5e<53bec5e>. I also added a test so I will notice if it breaks again. I think it should work for you now after you reinstall from the master branch (and reset your R session). Let me know! Ethan — Reply to this email directly, view it on GitHub<#28 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7RAOHFKBKDKNMZMT3VDWWDXX2RXVANCNFSM6AAAAAA4DXXPPI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

Answer 3 · 2023-08-30T06:14:30.000Z

It works! Thanks – useful plot for someone wanting to reassure themselves about how well get_peaktable works Ben From: Ethan Bass ***@***.***> Reply to: ethanbass/chromatographR ***@***.***> Date: Wednesday, 30 August 2023 at 12:43 To: ethanbass/chromatographR ***@***.***> Cc: Ben Moore ***@***.***>, Author ***@***.***> Subject: [External] Re: [ethanbass/chromatographR] stripplot failure in get_peaktable (Issue #28) Hi Ben, Thank you very much for pointing this out. It seems I broke the code for the plot a while ago, but I didn't realize it since I don't use that plot very often. This should be fixed by 53bec5e<53bec5e>. I also added a test so I will notice if it breaks again. I think it should work for you now after you reinstall from the master branch (and reset your R session). Let me know! Ethan — Reply to this email directly, view it on GitHub<#28 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7RAOHFKBKDKNMZMT3VDWWDXX2RXVANCNFSM6AAAAAA4DXXPPI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

Answer 4 · 2023-08-30T13:10:41.000Z

Yes, thanks again for pointing this out and glad to hear it's working now!
Ethan