fastobo/fastobo-py

Add an arm64.whl for fastobo to pypi releases

cmungall opened this issue · 6 comments

cmungall commented

Currently I am trying to combine ensmallen and fastobo in one package (oakx-grape) on an M1 Mac

Using ensmallen 0.8.28, which has an arm64.whl
https://pypi.org/project/ensmallen/0.8.28/#files

I don't see an equivalent for fastobo

This results in:

  File "/Users/cjm/Library/Caches/pypoetry/virtualenvs/oakx-grape-pUaGkv-X-py3.9/lib/python3.9/site-packages/pronto/xref.py", line 6, in <module>
    import fastobo
ImportError: dlopen(/Users/cjm/Library/Caches/pypoetry/virtualenvs/oakx-grape-pUaGkv-X-py3.9/lib/python3.9/site-packages/fastobo.cpython-39-darwin.so, 0x0002): tried: '/Users/cjm/Library/Caches/pypoetry/virtualenvs/oakx-grape-pUaGkv-X-py3.9/lib/python3.9/site-packages/fastobo.cpython-39-darwin.so' (mach-o file, but is an incompatible architecture (have (x86_64), need (arm64e)))

AFAICT I can't use ensmallen in x86 mode (cc @justaddcoffee) so I seem to be stuck here

I've been told that building arm wheels automatically as part of CI is hard, but I found this, don't know how hard this would be to integrate:

https://github.com/pypa/cibuildwheel

ravwojdyla commented

FYI this is a duplicate of #302

althonos commented

@cmungall : I updated the CI/CD today so there are now aarch64 wheels for MacOS for a pre-release, would you mind trying them (pip install -U fastobo --pre)? If they work as intended, I'll make a proper release.

cmungall commented

@pkalita-lbl tested this on his M1 mac, we believe this to be working, thanks!

althonos commented

Cool, thanks!

kevinschaper commented

It's working for me too, thanks for the fix!

  • 🚀1
althonos commented

Nice! I'll release a proper v0.12.2 and yank v0.12.1 to prevent problems at installation.

  • 👍1