fivetran/dbt_ad_reporting

[Feature] Allow for url report to include non url records

fivetran-joemarkiewicz opened this issue · 2 comments

fivetran-joemarkiewicz commented

Are you a current Fivetran customer?

Fivetran created PR.
What change(s) does this PR introduce?

  • For use in the dbt_ad_reporting package, users can now allow records having nulls in url fields to be included in the ad_reporting__url_report model.
  • Disabled the not_null test for ad_reporting__url_report when null urls are allowed

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature #59
  • No

How did you test the PR changes?

  • BuildKite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🍝

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

fivetran-joemarkiewicz commented

My idea for a solution would be to add a variable to the relevant code line within the respective platform transform package [platform]__url_report model.

-- Example from Google Ads
    -- We only want utm ads to populate this report. Therefore, we filter where url ads are populated.
    where ads.source_final_urls is not null

And include a variable that allows users across all packages to switch the filter off if they desire.

fivetran-joemarkiewicz commented

Closing this Issue as the above PRs have been merged and address this feature.