fmi-faim/faim-ipa

BoundingBox5D overlap check is slow

tibuch opened this issue · 0 comments

tibuch commented

The BoundingBox5D.overlaps check is not very performant:
https://github.com/fmi-faim/faim-hcs/blob/b9f1448260ac9c894dd4a2fe4829a440ef5ddba3/src/faim_hcs/stitching/BoundingBox5D.py#L116

Currently we check for each corner point of a 5D box (32 points) if it is inside another box and vice versa.

This should be changed to return False as soon as one dimension does not overlap i.e. if the bounding boxes do not overlap in the time dimension, no overlap will be possible and we can return after the first dimension check.