Release tarball is missing BSD and GPL license files
ebiggers opened this issue · 2 comments
ebiggers commented
In jellyfish-2.3.0.tar.gz downloaded from the releases page, the LICENSE file says
See the files LICENSE-BSD-3-Clause and LICENSE-GPL-3.0 for details.
But these files are not included in the tarball.
The probably need to be added to EXTRA_DIST in Makefile.am.
mmokrejs commented
Seems 2.3.0 was silently re-released, which broke Linux distros checking checksum of the release tar.gz file. At the moment I see (note the changed files in 2020):
-rw-r--r-- 1 5009 5000 278 Mar 29 2018 jellyfish-2.0.pc.in
-rw-r--r-- 1 5009 5000 14918 Mar 29 2018 config.rpath
-rwxr-xr-x 1 5009 5000 588 Jul 13 2019 gtest.mk
-rw-r--r-- 1 5009 5000 627 Jul 13 2019 compat.sh.in
-rw-r--r-- 1 5009 5000 35147 Jul 13 2019 LICENSE-GPL-3.0
-rw-r--r-- 1 5009 5000 1502 Jul 13 2019 LICENSE-BSD-3-Clause
-rw-r--r-- 1 5009 5000 7039 Jul 13 2019 configure.ac
-rw-r--r-- 1 5009 5000 2473 Jul 13 2019 README
-rw-r--r-- 1 5009 5000 324412 Aug 23 2019 ltmain.sh
-rw-r--r-- 1 5009 5000 99133 Aug 23 2019 aclocal.m4
-rwxr-xr-x 1 5009 5000 670519 Aug 23 2019 configure
-rw-r--r-- 1 5009 5000 5264 Aug 23 2019 config.h.in
-rwxr-xr-x 1 5009 5000 4640 Aug 23 2019 test-driver
-rwxr-xr-x 1 5009 5000 6872 Aug 23 2019 missing
-rwxr-xr-x 1 5009 5000 15155 Aug 23 2019 install-sh
-rwxr-xr-x 1 5009 5000 23567 Aug 23 2019 depcomp
-rwxr-xr-x 1 5009 5000 36136 Aug 23 2019 config.sub
-rwxr-xr-x 1 5009 5000 44283 Aug 23 2019 config.guess
-rwxr-xr-x 1 5009 5000 7333 Aug 23 2019 compile
-rw-r--r-- 1 5009 5000 9836 Feb 5 2020 Makefile.am
drwxr-xr-x 2 5009 5000 4096 Feb 5 2020 m4
drwxr-xr-x 3 5009 5000 4096 Feb 5 2020 include
-rw-r--r-- 1 5009 5000 176846 Feb 5 2020 Makefile.in
drwxr-xr-x 3 5009 5000 4096 Feb 5 2020 unit_tests
drwxr-xr-x 2 5009 5000 4096 Feb 5 2020 tests
drwxr-xr-x 5 5009 5000 4096 Feb 5 2020 swig
drwxr-xr-x 2 5009 5000 4096 Feb 5 2020 sub_commands
drwxr-xr-x 2 5009 5000 4096 Feb 5 2020 lib
drwxr-xr-x 2 5009 5000 4096 Feb 5 2020 jellyfish
drwxr-xr-x 2 5009 5000 4096 Feb 5 2020 doc
$ grep EXTRA_DIST jellyfish-2.3.0.new/Makefile.am | head -n 1
EXTRA_DIST = doc/jellyfish.pdf doc/jellyfish.man README LICENSE-BSD-3-Clause LICENSE-GPL-3.0 # jellyfish.spec
$