humanoid-path-planner/hpp-fcl

FCL building in Github Actions uses wrong Python version

rayzchen opened this issue · 10 comments

jcarpent commented

Thanks @rayzchen for raising this issue. I've just opened a new PR #427 fixing it.

rayzchen commented

I don't think that is going to fix the problem, since it is currently using Python 3.11 and disregarding the python-version option.

jcarpent commented

Yes, you're right. I've updated the version of goanpeca/setup-miniconda.

rayzchen commented

Is there a particular reason why goanpeca/setup-miniconda is used instead of conda-incubator/setup-miniconda?

jcarpent commented

Except for historical reasons, no. I've just changed it.

jcarpent commented

Fixed via #427.

rayzchen commented

I believe it still is creating a Python 3.11 module, since https://github.com/humanoid-path-planner/hpp-fcl/actions/runs/5122067821/jobs/9210618055#step:5:8654 shows that it cannot find hppfcl.hppfcl, which should point to a file called hppfcl.cp310-win_amd64.pyd, but the file found there (from my fork of this repo that saves the generated Python files) is called hppfcl.cp311-win_amd64.pyd. This would cause a ModuleNotFoundError in Python.

jcarpent commented

Perfect. Thanks for the report. I was only looking at the cmake configuration.
I will look at it.

jcarpent commented

@rayzchen I've found the issue which is not due to Conda and the CI, but rather the way we proceed for the packaging of the project. I will investigate it later with @fabinsch.

rayzchen commented

Sorry, my bad, my fork had merge conflicts which weren't resolved correctly and still used v1 of the setup-miniconda action. Once fixed, the correct version of Python was used. It seems that I tried to link two separate problems together.