iVis-at-Bilkent/newt

Rename source and sink to empty set

ugurdogrusoz opened this issue · 5 comments

The latest SBGN PD names these nodes "Empty set", so let's rename them. Let's review other node (glyphs) and edge (archs) types as well.

The related tests failed because the link in the test points to master version of one of our files which had the source and sink to empty set change.

Let's find out whether "source and sink" should be used in SBGNML's when reading and writing with the UI using "empty set".

Let's accept both "source and sink", "empty set", and "emptyset" when reading. For writing, let's keep using "source and sink" since SBGNML is still outdated in this respect. The UI should refer to the node with the new name "empty set" though.

This map with a single process passes the checks in public Newt but not the daily build. Could this be related to not renaming / using the new node class name?
Screenshot 2021-06-07 111403

Since SBGNML, other tools, validator, etc. might be referring to the old name, let's keep this issue open for a while.