iVis-at-Bilkent/newt

SBGN brick: Metabolic reaction

Closed this issue · 9 comments

  • 1. Let's get rid of "Type:" in front of the combo box
  • 2. "?" should take the user to the associated bricks' page and its tooltip should be "Associated brick web page"
  • 3. Regulator, Input, Output should all be regular (not boldface)
  • 4. Regular, Input and Output subsections should have light gray borders to form logical sub-units
  • 5. Input and Output titles should be closer to the input and output lists respectively
  • 6. Checkbox for multimer should be a little apart from the combo box before it
  • 7. When the Regulator type is changed while Multimer is checked, we should reset the multimer checkbox
  • 8. When Regulator is disabled, regulator label and "Multimer" should also become grayer to indicate being disabled
  • One minor issue is when the multimer checkbox is disabled (due to the type of the regulator), we should also disable (make grayer) the text "Multimer" as well:
    Screenshot 2021-04-22 151254

In addition, as suggested by Alexander:

  • Let's move the preview to the right side (instead of top), make it a square area, with a combo box at the top for the orientation (Left-to-right and Top-to-bottom)
  • Let's show the main metabolites (first input and first output) horizontally (vertically) aligned with the process, then tile the remaining from top to bottom (left to right) to have an equal input (output) on both sides of the main metabolite.

Looks great.

  • One final improvement is the length of the arc from the regulator to the process. Can we please decrease that to the same value as well?
  • We also need to add the new icon on the toolbar to the UI Guide under Help.

"Maybe one more (optional) improvement aesthetics-wise: would be great to allow some more padding for the image in the window, like 5-10 pixels. "

  • When Multimer is checked for Regulator, we should enable the count (2 by default) next to "Multimer" and allow it to be an integer that is 2 or more. This will be reflected in the macromolecule as a Unit of Information with label "N:2", "N:3", etc.
  • Turns out a catalysis arc cannot be connected to Nucleic acid feature, Perturbing agent, and Source and sink. So, let's remove these from the associated dropdown box.

One minor issue here that I can type 0 for multimer count.

0 is converted to 2 now but I can type just "-" now and leave it like that (which wasn't possible before I think):
Screen Shot 2021-05-10 at 17 24 50

  • Let's please change the tooltip for multimer count to "Integer value of at least 2"
  • This count should be grayed out unless Multimer is checked.
    Screenshot 2021-05-11 133636
  • change multimer count infobox to "unit of information" (not "state variable")
  • let's leave as much space as possible between the reversible checkbox and the regulator group so it's not associated with the regulator