imsweb/algorithms

Revert back field name change for AYA algorithm

depryf opened this issue · 1 comments

When I added a new version of that algorithm, I added a new variable called "aya-site-recode-2020".

Because I added a "version suffix" to that one, I also renamed the existing "aya-site-recode" to "aya-site-recode-2008".

After discussing this with a few people, this change could cause some problems if that variable was added to some user-defined NAACCR XML dictionaries.

I think we can still rename a field if we really have to, but that will possibly create some extra work for some people, and we have to be really sure it's necessary.

Renaming it just to be consistent doesn't feel like a good reason.

I am going to revert back that change and keep the old name.

I am going to keep the label of that existing variable to "AYA Site Recode 2008" to make it clear it's the "old" variable. Labels shouldn't affect anything, and so I feel like that change is safe.

Adding @flynngr for notification.

This is done.