Use subprocess.run/check_output/… in examples

Question

Use subprocess.run/check_output/… in examples

Closed this issue 2 years ago · 1 comments

using string interpolation to construct commands is a really bad practice. You do so prominently in your examples by using os.system. This will break as soon as one of the paths contains a space, unlike using subprocess.run(['cmd', path], check=True)

Answer 1 · 2022-07-25T08:16:19.000Z

Why did you close this? The README still contains calls to os.system