Issue Pulling Misc. Team Stats - Defense without Defining a 'season'

[ashayotovich]

I am working on using the package to pull the Miscellaneous Team Stats - Defense page and am encountering an error. I successfully pulled the Offense page with the first line, but the second line (to pull the defense data) is bombing.

In your summary.py file where you define your get_teamstats function, it looks like there is a small typo on line 150:
url = url + '?od=d'

the '?' should be an '&' sign.

You have this correct in line 147, but since that is within the 'if season:' loop, it forces the user to insert a season. By updating line 150 to the correct syntax, I think it would allow users to request the Defense data without defining a season (which on the website defaults to current season).

As I was writing this, inserted a value for 'season' and was able to pull the data. Just a potential enhancement I noticed. Thanks for the package, its awesome!

[j-andrews7]

Hey, thanks for finding and troubleshooting this. I am certain there are other bugs - I haven't touched this in over a year and I'm sure Ken's updated his site since then. I definitely need to get back to it since basketball's back again, the tests have been screaming at me that some have been failing for months. Maybe this will be the impetus to get me going on it again since it's such an easy fix.

…

On Thu, Feb 4, 2021, 12:30 PM ashayotovich ***@***.***> wrote: I am working on using the package to pull the Miscellaneous Team Stats - Defense page and am encountering an error. I successfully pulled the Offense page with the first line, but the second line (to pull the defense data) is bombing. [image: image] <https://user-images.githubusercontent.com/78546960/106938491-0dd0c480-66ed-11eb-84f2-17f9fa93d480.png> In your summary.py file where you define your get_teamstats function, it looks like there is a small typo on line 150: url = url + '?od=d' the '?' should be an '&' sign. You have this correct in line 147, but since that is within the 'if season:' loop, it forces the user to insert a season. By updating line 150 to the correct syntax, I think it would allow users to request the Defense data without defining a season (which on the website defaults to current season). [image: image] <https://user-images.githubusercontent.com/78546960/106938310-cfd3a080-66ec-11eb-872c-6f5982ed570e.png> As I was writing this, inserted a value for 'season' and was able to pull the data. Just a potential enhancement I noticed. Thanks for the package, its awesome! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACOAQNHFMC63FQVTCWUGPU3S5LRTLANCNFSM4XDKOVIA> .

[j-andrews7]

This should be fixed in the latest release.