johannesugb/VolumetricLinesUnity

Add Single Pass Instanced Rendering support

johannesugb opened this issue · 8 comments

johannesugb commented

Support for Single Pass Instanced Rendering has been requested.
Further information: https://docs.unity3d.com/Manual/SinglePassInstancing.html

ilmatematico commented

agree, with VR only left eye is rendering the eye in SPI

jonathanmorlen commented

Only my left eye is rendering as well.

johannesugb commented

Can you confirm that the problem persists with the latest version? I.e. which includes the changes of commit f6569bc

jonathanmorlen commented

Yes, just checked the _LineStripShader.cginc and it has all the changes from that commit. I am using an HP Reverb. and Unity 2020.2.6f1

jorgeolothar commented

Any progress on this issue?

johannesugb commented

Yes, there is a potential fix. I've updated all branches some minutes ago with code that has been reported to fix the single pass instanced rendering issue. I have yet to test myself in VR, but maybe if you could checkout the code and report back if it has solved it for you, that would help a lot.

Just ensure that you checkout the code from the appropriate branches, i.e. those targeting with the most up-to-date Unity editor versions, I suppose, which are:

I'll wait a few days for feedback and try to test myself in VR before I'll update the assets in the Asset Store.

jorgeolothar commented

Those changes worked.
Tested on Unity 2021.1.19, OpenVR (Steam Valve Index , Single Pass Instanced) and Oculus (Rift, Single Pass Instanced)

  • 👍1
johannesugb commented

Thank you :)