Issue with lambda callbacks
Closed this issue · 3 comments
tmitchellgcio commented
We are using non-async handlers with a callback function. Not a fan of it, but it's what I've been given. Anyways, it seems the handler is only sending back event and context and not the callback so the callback keeps getting the error done is not a function
. Done being our callback name.
juanjoDiaz commented
Hi @tmitchellgcio ,
Yes, this plugin has only been implemented for async handlers.
Callback-based handlers would need to be implemented.
Unfortunately, I don't have time to work on this at the moment.
In any case, I recommend that you try to migrate to async handlers as they are cleaner and simpler.
tmitchellgcio commented
Yep I think I convinced them to move to async handlers
Sent from my T-Mobile 5G Device
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Juanjo Diaz ***@***.***>
Sent: Monday, March 6, 2023 7:41:47 AM
To: juanjoDiaz/serverless-middleware ***@***.***>
Cc: Mitchell, Taylor ***@***.***>; Mention ***@***.***>
Subject: Re: [juanjoDiaz/serverless-middleware] Issue with lambda callbacks (Issue #46)
Hi @tmitchellgcio<https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftmitchellgcio&data=05%7C01%7Ctaylor.mitchell%40govcio.com%7C309f585db0d549235cea08db1e40275d%7C6499e3f51d3e4f099ad352b9e2f67fb8%7C1%7C0%7C638137033139270517%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WyG6sNhzszDw7yVwY7cFx2FgAWzU6Xuxk59BNVp99A8%3D&reserved=0> ,
Yes, this plugin has only been implemented for async handlers.
Callback-based handlers would need to be implemented.
Unfortunately, I don't have time to work on this at the moment.
In any case, I recommend that you try to migrate to async handlers as they are cleaner and simpler.
—
Reply to this email directly, view it on GitHub<https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FjuanjoDiaz%2Fserverless-middleware%2Fissues%2F46%23issuecomment-1456063490&data=05%7C01%7Ctaylor.mitchell%40govcio.com%7C309f585db0d549235cea08db1e40275d%7C6499e3f51d3e4f099ad352b9e2f67fb8%7C1%7C0%7C638137033139270517%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QIA7rSJW0V09TAaB%2FGsh29oYgJ5fKzfhOlIQugdU7fU%3D&reserved=0>, or unsubscribe<https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUG7736W2EFRIZ4ZGZYANWLW2XLQXANCNFSM6AAAAAAVN4VYYY&data=05%7C01%7Ctaylor.mitchell%40govcio.com%7C309f585db0d549235cea08db1e40275d%7C6499e3f51d3e4f099ad352b9e2f67fb8%7C1%7C0%7C638137033139426751%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=d7cTKpSGFfm04qolFZncwFZ4aTHfVD%2B0NnENGluS2co%3D&reserved=0>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
juanjoDiaz commented
Awesome!
Closing this then 🙂