Request to merge the customized new features into official version

Question

Request to merge the customized new features into official version

Lina-LI-Na opened this issue 4 years ago · 11 comments

Dear Developers,
Thank you very much for your great support and response to my earlier request.

We understand your concern about the extra customize and maintenance workload. If we work with Moodle partner Catalyst to develop the customized features, would it possible to merge these features into the official version of fair allocation?

These new features could also benefit other users of the Moodle community and we are happy to pay the cost of the official version's maintenance of this part. The customized features include bulk upload choice in CSV file, add group restriction to each choice, upload attachment for each choice, and manually allocate student for each choice before the auto allocation.

Looking forward to your reply.

Thank you very much.

Best regards,
Lina

Answer 1 · 2021-01-20T08:28:58.000Z

Hey Lina,
thanks for your information and the effort you put in!
What do you mean by

we are happy to pay the cost of the official version's maintenance of this part

Does that mean that you pay catalyst for every moodle update or only for the versions which you are using?
We try to get early bird batches for all our plugins so we maintain all versions which would be the goal. However, I can imagine you do not want to have those cost.

Best regards,
Nina

Answer 2 · 2021-01-20T09:36:37.000Z

Hey Nina,
Thank you very much for your kind reply.
We are happy to explore it with Catalyst financially before we can commit to it.

May I double check with you what do you mean by

We try to get early bird batches for all our plugins so we maintain all versions which would be the goal.

Does that mean all the historical versions and future new versions?
If we can pay catalyst for the maintenance of all versions, would you be willing to accept our codes with the new features in the official plugin?

Many thanks for your great contributions and support again.

Best regards,
Lina

Answer 3 · 2021-01-20T10:04:07.000Z

Hey Lina,

I only meant future versions. Early Bird badges mean we have a finished version of the plugin by the release date of the new version. (Which means having previous alpha/beta version testing)
I would be happy if you can inform me if that is doable for you and catalyst.

Cheers,
Nina

Answer 4 · 2021-01-20T10:56:14.000Z

Hey Nina,
Yes, we are happy to support all future versions.
Thank you very much. If your team is willing to accept our codes, we will start to work with Catalyst for the developement and keep you posted for any update.
Many thanks.

Cheers,
Lina

Answer 5 · 2021-02-19T01:34:45.000Z

Hi Team,

just picking up the work proposed by @Lina-LI-Na

I see many of the improvements they are after are already covered in issues like #37, #16 and a slight variation on #20 (allowing any file to be provided - eg a supplementary PDF) - so assuming you were happy with the structure of a pull request and it ticked all the boxes regarding tests/compliance etc. I'm guessing there's an interest in receiving a pull request with those improvements,
but there's one improvement that I don't think is quite covered so I've just created #208 that covers this a bit.

We're still pricing the proposed work on our end but it would be good to hear if you are interested in the concept behind #208 and or/if there are any specific things you'd like to see in that work before you were interested in having it become part of your core release.

thanks!

Answer 6 · 2021-02-22T08:55:55.000Z

Hey @danmarsden,
generally, we are interested in the improvements. However, as you know reviewing takes a lot of time so it would be nice if we could have multiple pull requests for small improvements rather than one big one.
Cheers,
Nina

Answer 7 · 2021-06-16T02:05:32.000Z

Thanks @NinaHerrmann - as you've probably seen we've started submitting some PR's related to this - feel free to close this particular issue off as the actual work will be covered in PR's or in specific issues.

I'm trying to make sure we submit the PR's in order and with small chunks to make it easier for you to review on your end - but please let me know if there's anything missing or anything we can do to make it easier for you to review.

After we get the pagination (#218) and group stuff (#219) into a state you're happy with we'll be looking at CSV import of choices (#16) and then the more complex manual allocation (#208) - we'll try to split the work from #208 into a few different PR's to make it easier to review.

Answer 8 · 2021-07-19T02:34:51.000Z

Hi @NinaHerrmann - have you got anyone that will be able to review our PR's soon? - would be really good if we could address any feedback you might have before we run out of budget on our end - we really don't want to maintain a separate fork if we can avoid it!!

thanks!

Answer 9 · 2021-07-19T08:52:01.000Z

Hey @danmarsden thanks for splitting the PRs, I try to get as much as possible done today 👍

Answer 10 · 2021-07-19T22:44:57.000Z

Thanks for getting started on these @NinaHerrmann - great to see some of it merged in already! - We've got a csv import PR incoming soon and then will be looking into #208 which we expect to be a bit more complex.

thanks again!

Answer 11 · 2023-05-26T12:15:38.000Z

Thank you for providing those features!