Possible unnecessary error checking loading from included contexts
Opened this issue · 1 comments
While investigating monarch-initiative/monarch-app#819, I noticed a bottleneck in loading the "merged" context in these lines in curie:
Is it necessary to check for duplicate prefixes on known-good prefix maps (i.e. those bundled with this package)? If not, the converter loaded here:
prefixmaps/src/prefixmaps/io/parser.py
Lines 30 to 31 in c61e812
can be initialized with strict=False
, resulting in a speedup of about ~15s on the "merged" context. I am happy to create a PR if that sounds okay.
To be clear, strict=False
would be added as a keyword to the .from_extended_prefix_map
method here:
prefixmaps/src/prefixmaps/datamodel/context.py
Lines 379 to 386 in c61e812