mavlink/MAVSDK-Swift

Cancel mission upload and download now working currently

douglaswsilva opened this issue · 4 comments

douglaswsilva commented

I'm testing the latest SDK with latest firmwares and it seems that this got broken.
I call the .cancelMissionUpload() command, but it doesn't cancel and there's no callback until the mission finishes uploading. Then I get this:

[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Debug] Send mission item 87 (mission_impl.cpp:1118)
[05:31:58|Info ] Mission accepted (mission_impl.cpp:165)
17:31:58.041 📰 [DroneIntegrationTestViewController.swift:136 uploadMission()]: +DIT+ Mission Uploaded.
[05:31:58|Warn ] No mission upload in progress (mission_impl.cpp:398)
17:31:58.052 📰 [DroneIntegrationTestViewController.swift:149 cancelMissionUpload()]: +DIT+ Mission Canceled.
julianoes commented

Thanks for the report. I'll check that. Are you testing that against H520 with current firmware?

julianoes commented

I'm actually quite confused about this one because we have an integration test that tests mission cancel in CI 🤔 .

  • 👍2
douglaswsilva commented

Hm, I wonder if it could be something on our side or the firmware side. I'm going to test it in SITL and see what I get. Thanks for letting me know.

UPDATE: It seems that something broke the background scheduler we use to subscribe to cancelMissionUpload in our app, which might be causing the problem. I'm going to test more now subscribing in different threads and see what I get and let you know.

douglaswsilva commented

Yep, changing the scheduler for cancelMissionUpload.subscribeOn(scheduler) fixed it.
Thanks for the reply! Closing.

  • 👍2