mims-harvard/TDC

add requests to requirements.txt

SzilviaKiriakov opened this issue · 4 comments

I am reproducing the code from the website to access the TAP dataset on Python-3.8.5. with pip installation of PyTDC-0.3.6 (macOS), but cannot load the dataset.

from tdc.utils import retrieve_label_name_list
Traceback (most recent call last):
File "", line 1, in
File ".pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/init.py", line 1, in
from .evaluator import Evaluator
File ".pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/evaluator.py", line 7, in
from .utils import fuzzy_search
File ".pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/utils/init.py", line 1, in
from .load import distribution_dataset_load,
File ".pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/utils/load.py", line 3, in
import requests
ModuleNotFoundError: No module named 'requests'

I get the same error with SAbDab_Chen dataset.

from tdc.single_pred import Develop
Traceback (most recent call last):
File "", line 1, in
File "pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/init.py", line 1, in
from .evaluator import Evaluator
File ".pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/evaluator.py", line 7, in
from .utils import fuzzy_search
File ".pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/utils/init.py", line 1, in
from .load import distribution_dataset_load,
File "pyenv/versions/python-3.8.5/lib/python3.8/site-packages/tdc/utils/load.py", line 3, in
import requests
ModuleNotFoundError: No module named 'requests'

please use "pip install requests" to install requests pkg.

Thank you, that worked. So I assume here requests should be listed as an additional dependency, it was just missed.

yes. it is additional.

yeah i think we probably need to update the requirements.txt.